-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): style insert order for UMD builds (fix #13668) #13669
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Hey @sapphi-red , just a gentle bump here :) We are blocked on using |
@binary-koan you don't need to be blocked by this PR. Use https://pnpm.io/cli/patch or https://www.npmjs.com/package/patch-package so you can use this PR in your project until it is released. |
@sapphi-red Makes sense! Updated to do the right thing for both (inserting after "use strict" for UMD and after "execute:" for legacy) - seems to work nicely in the reproduction cases for both the previous issue and my issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
Fixes #13668
The previous fix in #13266 can break the insertion order for UMD builds when a dependency containing the string
execute:
is added. This updates the logic to only check forexecute:
whenSystem.register
is found, which should be a more robust way to find the insertion point.TLDR
System.register
calls will insert the CSS in theexecute
functionAdditional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).Submitted with StackBlitz Codeflow.