Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): remove restart guard on restart #13789

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix(server): remove restart guard on restart #13789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/vite/src/node/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,9 +852,7 @@ async function restartServer(server: ViteDevServer) {

await server.close()

// prevent new server `restart` function from calling
newServer._restartPromise = server._restartPromise

// Assign new server props to existing server instance
Object.assign(server, newServer)

const {
Expand All @@ -881,9 +879,6 @@ async function restartServer(server: ViteDevServer) {
shortcutsOptions.print = false
bindShortcuts(newServer, shortcutsOptions)
}

// new server (the current server) can restart now
newServer._restartPromise = null
}

async function updateCjsSsrExternals(server: ViteDevServer) {
Expand Down