-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove CJS ssr output format #13944
Conversation
Run & review this pull request in StackBlitz Codeflow. |
/ecosystem-ci run |
This comment was marked as outdated.
This comment was marked as outdated.
Vue projects are failing because of this conditional in vite-plugin-vue. Qwik has a conditional on |
/ecosystem-ci run |
This comment was marked as outdated.
This comment was marked as outdated.
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
This reverts commit e09ed15.
Added back the types temporarily so we can test ecosystem CI, see results here (same errors as in main). The change is reverted and only the |
Oops the fix foo comment closed this PR 😅 |
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
It seems laravel is failing with an error that could be a bug. I reran once so I guess it's not a flaky fail |
@dominikg, did you say the laravel fail happens in main too after updating vite-ecosystem-ci? I see it working here though: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/6194105986/job/16816620515 laravel/vite-plugin doesn't seems to be using this feature: https://github.com/search?q=repo%3Alaravel%2Fvite-plugin+buildSsrCjsExternalHeuristics&type=pullrequests |
laravel/vite-plugin uses vitest ^0.25.2 (0.25.8) and that might be the problem. |
I removed some more unused codes. |
I ran ecosystem-ci locally and the fail reproduced. After upgrading Vitest, the tests passed, so I created a PR: laravel/vite-plugin#246 |
Description
We're gathering feedback about the future removal of CJS SSR Format here:
This PR implements the removal to show the complexity that we'll be eliminating.
What is the purpose of this pull request?