Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use URL.canParse #14068

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 10, 2023

Description

Use URL.canParse (nodejs/node#47179, whatwg/url#763) if available that can skip the try-catch overhead.
I don't think this improves the perf much but we can simplify this by removing the fallback polyfill when it's ready.

Maybe we can bump the target to Node 18.17.0 instead of 18 in Vite 5? (#14030)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Aug 10, 2023
@stackblitz
Copy link

stackblitz bot commented Aug 10, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should wait to see what other features we get by bumping to 18.17.0. If it is only for this one, I think we could move forward without that using your helper. We are going to have another major before 18 goes EOL too if we want to bump it.

@patak-dev patak-dev merged commit dcee6ef into vitejs:main Aug 10, 2023
13 checks passed
@sapphi-red sapphi-red deleted the perf/use-url-can-parse branch August 10, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants