fix(glob): trigger HMR for glob in a package #14117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
has workaround
p3-downstream-blocker
|
|
sapphi-red
commented
Aug 16, 2023
Comment on lines
60
to
+64
| ) | ||
| ) | ||
| modules.push(...(server.moduleGraph.getModulesByFile(id) || [])) | ||
| ) { | ||
| const mod = server.moduleGraph.getModuleById(id) | ||
| if (mod) modules.push(mod) | ||
| } |
There was a problem hiding this comment.
An id (e.g. package/foo/index.js?v=version) is set here and server.moduleGraph.getModulesByFile(id) was returning [].
vite/packages/vite/src/node/plugins/importMetaGlob.ts
Lines 93 to 94 in 9b7b4ed
I guess it was wrong to use server.moduleGraph.getModuleById as the _importGlobMap uses an id instead of file.
Another way to fix this is to remove ?v=version before calling getModulesByFile or setting _importGlobMap.
patak-dev
approved these changes
Aug 16, 2023
bluwy
pushed a commit
that referenced
this pull request
Oct 3, 2023
bluwy
pushed a commit
that referenced
this pull request
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a package contained
import.meta.glob, adding a file within that glob didn't trigger HMR.fixes #10616
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).