Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: put manifest files in .vite directory by default #14230

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

sapphi-red
Copy link
Member

Description

Changes the default output path of manifest/ssrManifest to .vite/manifest.json/.vite/ssr-manifest.json.

fixes #9636

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p2-edge-case Bug, but has workaround or limited in scope (priority) breaking change labels Aug 29, 2023
@sapphi-red sapphi-red added this to the 5.0 milestone Aug 29, 2023
@stackblitz
Copy link

stackblitz bot commented Aug 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Sep 14, 2023

📝 Ran ecosystem CI: Open

suite result
analogjs ✅ success
astro ✅ success
histoire ❌ failure
ladle ❌ failure
laravel ✅ success
marko ✅ success
nuxt ❌ failure
nx ✅ success
previewjs ✅ success
qwik ✅ success
rakkas ❌ failure
sveltekit ✅ success
unocss ✅ success
vite-plugin-pwa ✅ success
vite-plugin-ssr ❌ failure
vite-plugin-react ✅ success
vite-plugin-react-pages ❌ failure
vite-plugin-react-swc ✅ success
vite-plugin-svelte ❌ failure
vite-plugin-vue ❌ failure
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success

@sapphi-red sapphi-red merged commit 74fa024 into vitejs:main Sep 18, 2023
11 checks passed
@sapphi-red sapphi-red deleted the feat/manifest-dot-vite-dir branch September 18, 2023 08:41
@Brain2000
Copy link

This just broke our build where the vite manifest was expected to be in the root folder, and we are still on 4.3.3. Weird...

@Brain2000
Copy link

Brain2000 commented Nov 16, 2023

It looks like pnpm dlx isn't using the package.json file for vite, so somehow it is using version 5.0.0 instead of 4.3.3....
npx vite shows version 4.3.3
pnpm dlx vite shows version 5.0.0

At least now I know where this is coming from...

tsnobip added a commit to tsnobip/rescript-relay-router that referenced this pull request Jan 17, 2024
manifest.json default path got moved into a .vite folder
cf vitejs/vite#14230
@gcaraciolo
Copy link

this pr introduces a bug in inertia-laravel in production. https://github.com/inertiajs/inertia-laravel

Inertia expects manifest.json to be at public/build. a quick fix was to provide this path in vite.config

@bluwy
Copy link
Member

bluwy commented Jan 18, 2024

@gcaraciolo you should report the issue to the repo. This is an intended breaking change in Vite 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manifest.json file collision
5 participants