fix(legacy): fix broken build when renderModernChunks=false & polyfills=false (fix #14324) #14346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14324
Description
Issue #14324 has a detailed explaination of the bug. In short, if the legacy plugin is configured with
renderModernChunks=false
&polyfills=false
then the outputted build is broken and unusable.This PR fixes the bug by including the ployfill chunk in this scenario, since the ployfill chunk contains SystemJS.
Additional context
I'm not sure how to add tests without creating an entirely new folder under
/playground
, since a test for this PR would require a differentvite.config.ts
file.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).