Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(create-vite): add qwik and qwik-ts to the list #14624

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

equal-l2
Copy link
Contributor

Description

Added the missing qwik and qwik-ts to the list in the README of create-vite.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@equal-l2
Copy link
Contributor Author

I'm participating Hacktoberfest 2023.
If you are fine with the event and if this PR is good to merge, please add a hacktoberfest-accepted label to this PR on merge.

(For detail, please refer "Maintainers" section of https://hacktoberfest.com/participation/ )

Thank you.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind adding the label, but we will have to create one and I'll defer that to @patak-dev if he's also ok with it.

@equal-l2
Copy link
Contributor Author

If you accept all hacktoberfest contributions from now on, alternatively you can add hacktoberfest topic on the repository, instead of add the label to each PR.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the label, thanks for the PR!

@patak-dev patak-dev merged commit de87fe4 into vitejs:main Oct 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants