-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow providing parent httpServer on middleware mode #14632
Conversation
Pretty sure you've thought about this, but what about overloading as |
I don't have a strong preference. Was thinking of avoiding bloating the config options, by moving this to an "API specific options" over the general Vite config. |
I think both options are good. If there is a chance there will later be more options related to I am thinking of |
I think I prefer |
I think it's best to avoid an extra option for Overloading |
Description
resolves #4124
I also encountered a similar issue when developing Nuxt DevTools. As stated in #4124, there is currently no userland workaround as
proxyMiddleware
isn't exposed publicly. The only way to proxy WebSocket on middleware mode is to re-implement the entire proxy mechanism of Vite, which I think hurts the DX for a built-in feature that is "supposed to work".Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).