Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: read modified file in buffer format #15046

Closed
wants to merge 1 commit into from
Closed

perf: read modified file in buffer format #15046

wants to merge 1 commit into from

Conversation

Plumbiu
Copy link
Contributor

@Plumbiu Plumbiu commented Nov 20, 2023

Description

content is not used if the modified file is empty, we can transform to string after.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

patak-dev
patak-dev previously approved these changes Nov 20, 2023
@sapphi-red
Copy link
Member

sapphi-red commented Nov 20, 2023

So I think the current implementation is faster.

@patak-dev patak-dev dismissed their stale review November 20, 2023 13:58

see sapphi's comment

@Plumbiu
Copy link
Contributor Author

Plumbiu commented Nov 20, 2023

So I think the current implementation is faster.

I see, i will close this pr

@Plumbiu Plumbiu closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants