Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legacy): support any separator before hash in fileNames #15170

Merged

Conversation

patak-dev
Copy link
Member

Description

Small followup to:

See comment: #15115 (comment)

Before this PR:

custom_[hash].[ext] -> custom_-template[hash].[ext]

Afterwards

custom_[hash].[ext] -> custom-template_[hash].[ext]

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev added p2-nice-to-have Not breaking anything but nice to have (priority) plugin: legacy labels Nov 28, 2023
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have a test for modern filename -> legacy filename conversion.

@patak-dev
Copy link
Member Author

Let's work on the tests to check the whole thing in another PR.

@patak-dev patak-dev merged commit ecab41a into main Nov 29, 2023
10 checks passed
@patak-dev patak-dev deleted the refactor/legacy-respect-file-names-separators-before-hash branch November 29, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority) plugin: legacy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants