-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(hmr): provide a separate logger interface #15631
Conversation
|
This looks fine to me if it's staying as internal. If it's public one day, I'm concerned that we would have to add new methods if we want to log something structurally, and it'll break third-party implementations.
Before logging, is there a way we can prettify the paths first? |
It is a public API for SSR logger at least.
Before the logging we are actually making them longer 😄 Maybe if we change the format SSR runtime stores them in, then we won’t need this logger 🤔 I‘ll try to investigate this first before we can merge this. |
An option could be to provide a |
@bluwy @patak-dev if we remove In vite-node PR this logger is a public API. The second point of this PR is irrelevant now, I refactored how modules are stored to make it more inline with how browser/ssr worked before. |
If we only have |
Updated 😄 (not a big change, huh) |
Description
This PR standardizes the HMR logger interface.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).