Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): pass path instead of fileURL to isFilePathESM #15908

Merged

Conversation

sapphi-red
Copy link
Member

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Feb 14, 2024
Copy link

stackblitz bot commented Feb 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red changed the title fix(runtime): pass path instead of fileURL to isFilePathESM fix(runtime): pass path instead of fileURL to isFilePathESM Feb 14, 2024
@@ -77,7 +77,7 @@ export async function fetchModule(
throw err
}
const file = pathToFileURL(resolved.id).toString()
const type = isFilePathESM(file, server.config.packageCache)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When file is file:///C:/Users/green/foo.js, file:///C:/Users/green is passed to findNearestPackageData.

const pkg = findNearestPackageData(path.dirname(filePath), packageCache)

Then, file:\C:\Users\green\package.json is passed to tryStatSync.
const pkgPath = path.join(basedir, 'package.json')

fs.statSync('file:\C:\Users\green\package.json') throws Error: ENOENT: no such file or directory, stat 'C:\Users\green\file:C:Usersgreenpackage.json' error.

I didn't actually create a reproduction though.

@patak-dev patak-dev enabled auto-merge (squash) February 14, 2024 13:32
@patak-dev patak-dev merged commit 7b15607 into vitejs:main Feb 14, 2024
11 checks passed
@sapphi-red sapphi-red deleted the fix/runtime-pass-path-isfilepathesm branch February 15, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants