Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-vite): use "solution" tsconfig so that vite.config.ts is type checked #15913

Merged
merged 3 commits into from
Jun 13, 2024

Commits on Feb 28, 2024

  1. feat(create-vite): pass -b to tsc so that vite.config.ts is checked

    Currently when running "pnpm run build" on a fresh Vite project using
    any of these templates, tsc doesn't fail when there are type errors
    in vite.config.ts, such as something obvious like:
    
        const foo: string = 123;
    
    Passing -b makes it run for all project references, meaning that
    vite.config.ts starts to be type checked too during build.
    
    In order to not generate a vite.config.js and vite.config.d.ts we
    need to make the main tsconfig.json have nothing but references
    to tsconfig.node.json and a new tsconfig.app.json, as is done
    in the create-vue project, see:
    https://github.com/vuejs/create-vue/blob/f75fd9813a624b8e44b012608335721901aba00b/template/tsconfig/base/tsconfig.json
    philbates35 committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    07358e4 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Configuration menu
    Copy the full SHA
    0201552 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eb25276 View commit details
    Browse the repository at this point in the history