Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): reloading fails in non-browser environments #16368

Closed
wants to merge 1 commit into from

Conversation

keyding
Copy link
Contributor

@keyding keyding commented Apr 6, 2024

After fixing the #16318 issue, there is a new issue that fails to reload when there is a modification in a non-browser environment (chrome extension's backgorund.js).

Copy link

stackblitz bot commented Apr 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red
Copy link
Member

This will cause errors in workers. It seems vite-plugin-web-extension modifies /@vite/client. I think it should be done there instead.

@keyding
Copy link
Contributor Author

keyding commented Apr 7, 2024

This will cause errors in workers. It seems vite-plugin-web-extension modifies /@vite/client. I think it should be done there instead.

Thanks for the reply, I think I know what to change.

@keyding keyding closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants