fix(mergeConfig): don't recreate server.hmr.server instance #17763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
mergeConfig
function recursively goes through objects and overrides them. This works for the most part, except for theserver.hmr.server
property which is aServer
class/object.The problem is that the
mergeConfig
function treats it like a normal JS object and effectively clones it. This turns it into a standard object which doesn't work. And it also breaks reference to the object.We either need to modify the
isObject
function to check for classes, or for now, I've added an if statement to handle the special case, following the other precedence.