-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update misc #17863
Merged
patak-dev
merged 5 commits into
vitejs:v6/environment-api
from
sapphi-red:docs/misc-update
Aug 20, 2024
Merged
docs: update misc #17863
patak-dev
merged 5 commits into
vitejs:v6/environment-api
from
sapphi-red:docs/misc-update
Aug 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
sapphi-red
commented
Aug 11, 2024
Comment on lines
-95
to
-100
|
||
/** | ||
* Fetch information about a module from the module runner without running it. | ||
* Note: This method may not be needed | ||
*/ | ||
async fetchModuleInfo(url: string) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this one as I didn't find it in the code.
patak-dev
reviewed
Aug 20, 2024
Comment on lines
+4
to
+5
/guide/api-vite-runtime /guide/api-vite-environment 302 | ||
/guide/api-vite-runtime.html /guide/api-vite-environment 302 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these details ❤️
patak-dev
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
small changes