Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use optimizeDeps.entries #17962

Merged

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 28, 2024

Description

SvelteKit sets optimizeDeps.entries and have tests that expects the dependencies in other pages to be optimized before accessing (https://github.com/sveltejs/kit/blob/45cb8c5f305b4d9e61a32e19af8059dc0da4c255/packages/kit/test/apps/dev-only/test/test.js#L90-L98).

This PR merges the values in optimizeDeps.entries into environment.client.dev.optimizeDeps to fix that fail.

refs #17957 (comment)

Copy link

stackblitz bot commented Aug 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red
Copy link
Member Author

/ecosystem-ci run sveltekit

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on b222c03: Open

sveltekit

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Thanks for the fix @sapphi-red!
Awesome to see SvelteKit green 🙌🏼

@patak-dev patak-dev merged commit 9a369aa into vitejs:v6/environment-api Aug 28, 2024
9 checks passed
@sapphi-red sapphi-red deleted the fix/use-optimize-deps-entries branch August 28, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants