fix(build): declare preload-helper
has no side effects
#18057
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When there's is at least one dynamic import and the modulePreload is false, it will introduce a
detectScriptRel
function. But when the content imported dynamically is unused, thedetectScriptRel
will not be tree-shaken.Minimum reproductible set: https://stackblitz.com/edit/vitejs-vite-8iwu7r?file=src%2Fmain.ts
There is a
b.ts
which exports ab
:And a
a.ts
which exports aa
and ab
that dynamically importsb
fromb.ts
:Then only use
a
in entrymain.ts
.Finally bundle it. It will present a IIFE of
detectScriptRel
in the product:And the config of vite is: