Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(data-uri): only match ids starting with data: #18241

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix(data-uri): only match ids starting with data: #18241

merged 1 commit into from
Sep 30, 2024

Conversation

sapphi-red
Copy link
Member

Description

fixes #18219

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: build labels Sep 30, 2024
@stackblitz StackBlitz
Copy link

stackblitz bot commented Sep 30, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit ec0efe8 into vitejs:main Sep 30, 2024
12 checks passed
@sapphi-red sapphi-red deleted the fix/data-uri-stricter branch September 30, 2024 09:04
sapphi-red added a commit that referenced this pull request Oct 14, 2024
@sapphi-red
fix(data-uri): only match ids starting with data: (#18241)
96084d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
feat: build p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broad data uri regex captures wrong ids in resolveId
2 participants
@sapphi-red @patak-dev