-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(assets): make srcset parsing HTML spec compliant (#16323) #18242
Conversation
Run & review this pull request in StackBlitz Codeflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
HMR tests on Node 22 are a bit brittle :-/ The failure is unrelated to my changes and possible race condition/context leaking. I got another error on my machine just in the first run of tests. All consecutive runs were ok.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
fixes #16323
Description
Simplifies the spitting of
srcset
image candidates with descriptors, so it is compliant with spec and not driven by every edge case somebody finds out is not working.