Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: augment hash for CSS files to prevent chromium erroring by loading previous files #18367

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 16, 2024

Description

fixes #18038

augmentChunkHash is only called for chunks and not for assets. So I had to change the content to change the hash.

@sapphi-red sapphi-red added feat: css p4-important Violate documented behavior or significantly improves performance (priority) labels Oct 16, 2024
Copy link

stackblitz bot commented Oct 16, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also keep an eye in the future if our CSS handling pipeline has changes to the output, and if it does we could probably remove these code again.

@sapphi-red sapphi-red merged commit a569f42 into vitejs:main Oct 18, 2024
17 checks passed
@sapphi-red sapphi-red deleted the fix/augment-hash-for-css-files branch October 21, 2024 05:07
sapphi-red added a commit that referenced this pull request Oct 21, 2024
sapphi-red added a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.4.3 production bug
3 participants