Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): cssCodeSplit uses the current environment configuration #18486

Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix(css): cssCodeSplit uses the current environment configuration #18486

merged 1 commit into from
Nov 1, 2024

Conversation

Jonny-china
Copy link
Contributor

@Jonny-china Jonny-china commented Oct 28, 2024 •
edited by sapphi-red
Loading

Description

In the cssPostPlugin.generateBundle hook function, the top-level build.config.cssCodeSplit is used, and then the setting of cssCodeSplit in the current environment is invalid.

config.build.cssCodeSplit => this.environment.config.build.cssCodeSplit

refs #18464

@sapphi-red sapphi-red merged commit eefe895 into vitejs:main Nov 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
feat: css feat: environment API Vite Environment API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jonny-china @sapphi-red