Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): apply resolve.external/noExternal to server environments #18495

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 28, 2024

Description

Apply resolve.external/noExternal to server environments during build. Previously it only applied if config.build.ssr is set, and I'm not sure if that's intentional. Perhaps it's related to this:

// [feedback]
// is this still meant to be used?
// for example, `ssr: true` seems to make `minify: false` automatically
// and also externalization.
ssr: true,

@patak-dev patak-dev merged commit 5a967cb into main Oct 28, 2024
14 checks passed
@patak-dev patak-dev deleted the externalize-server-environments branch October 28, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants