fix: use server.perEnvironmentStartEndDuringDev
#18549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
p3-minor-bug
sapphi-red
commented
Nov 1, 2024
Comment on lines
521
to
525
| plugin.perEnvironmentStartEndDuringDev !== true, | ||
| config.server.perEnvironmentStartEndDuringDev || | ||
| plugin.perEnvironmentStartEndDuringDev === true, |
There was a problem hiding this comment.
I guess this was opposite.
There was a problem hiding this comment.
boolean conditions are the hardest ones 🤦🏼
patak-dev
previously approved these changes
Nov 1, 2024
patak-dev
reviewed
Nov 1, 2024
| await this.hookParallel( | ||
| 'buildEnd', | ||
| (plugin) => this._getPluginContext(plugin), | ||
| () => [], | ||
| (plugin) => | ||
| this.environment.name === 'client' || | ||
| plugin.perEnvironmentStartEndDuringDev !== true, | ||
| config.server.perEnvironmentStartEndDuringDev || | ||
| plugin.perEnvironmentStartEndDuringDev === true, |
There was a problem hiding this comment.
We can replace both plugin.perEnvironmentStartEndDuringDev === true with plugin.perEnvironmentStartEndDuringDev too, no?
There was a problem hiding this comment.
It required expanding hookParallel's type a bit, but it was possible 👍
patak-dev
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
server.perEnvironmentStartEndDuringDevwas not used anywhere.refs #18491 (comment)