fix(plugin-legacy): prevent dead code elimination from env.LEGACY marker #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaskuske
force-pushed
the
fix/env-legacy-constant-folding
branch
from
9c94168
to
b4b9538
Compare
|
Thanks for the suggested fix! I think even with a constant Array, this is not fundamentally safe since esbuild may one day improve its constant folding to even detect array literals containing only constants. This also made me realize that the previous I've refactored the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1999
close #2004 (also includes typo fix)
TL;DR:
Currently
if (import.meta.env.LEGACY)is treated asif ('__VITE_IS_LEGACY__')so it's always true.Likewise,
if (import.meta.env.LEGACY === true)is always false because it's treated asif ('__VITE_IS_LEGACY__' === true).This is due to esbuild's constant folding – using an array (or object) as marker the way it's implemented in this PR circumvents that.