-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ssr): resolve dynamic import vars modules #3177
Conversation
There are some failing tests (maybe windows related?) |
@Shinigami92 I already fixed test error=.= |
We cannot do review or merge it if windows is failing. You need to find out what the issue is and then try to get everything green 🙂 |
@underfin If you merge main, you are going to get better errors in the CI for windows |
619da28
to
014341d
Compare
@patak-js @Shinigami92 Sorry for many times bad fix. It is blue for all test. I think it is time for your reviews =.= |
Co-authored-by: Shinigami <chrissi92@hotmail.de>
fix: #3087
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).