Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): resolve dynamic import vars modules #3177

Merged
merged 4 commits into from
May 5, 2021

Conversation

underfin
Copy link
Member

fix: #3087

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92
Copy link
Member

There are some failing tests (maybe windows related?)

@underfin
Copy link
Member Author

@Shinigami92 I already fixed test error=.=

@Shinigami92
Copy link
Member

We cannot do review or merge it if windows is failing. You need to find out what the issue is and then try to get everything green 🙂

@patak-dev
Copy link
Member

@underfin If you merge main, you are going to get better errors in the CI for windows

@underfin
Copy link
Member Author

underfin commented May 5, 2021

@patak-js @Shinigami92 Sorry for many times bad fix. It is blue for all test. I think it is time for your reviews =.=

@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label May 5, 2021
@Shinigami92 Shinigami92 requested a review from patak-dev May 5, 2021 07:22
@patak-dev patak-dev merged commit b1e7395 into main May 5, 2021
@patak-dev patak-dev deleted the ssr-load-dynamic-import-vars branch May 5, 2021 07:57
fi3ework pushed a commit to fi3ework/vite that referenced this pull request May 22, 2021
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to load module for ssr
3 participants