fix: warn about dynamic import polyfill only during build #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
previously approved these changes
May 17, 2021
patak-dev
changed the title
|
We can actually safely warn during build, I restored the warning with this check |
antfu
approved these changes
May 17, 2021
antfu
approved these changes
May 17, 2021
nihalgonsalves
approved these changes
May 17, 2021
fi3ework
pushed a commit
to fi3ework/vite
that referenced
this pull request
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we are enabling the dynamic import polyfill only during build, we can not reliably warn about an unneeded import 'vite/dynamic-import-polyfill'. We can also not detect the legacy plugin, since the user may want to enable this plugin only without the full legacy build. This PR removes this warning. See related discussion in #3434
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).