Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate polyfillDynamicImport #4373

Merged
merged 4 commits into from
Jul 27, 2021
Merged

refactor: deprecate polyfillDynamicImport #4373

merged 4 commits into from
Jul 27, 2021

Conversation

patak-dev
Copy link
Member

Description

After #3885, users that want to target browsers that don't support dynamic import should use plugin-legacy. polyfillDynamicImport can now be deprecated in Vite core.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jul 23, 2021
@patak-dev patak-dev added this to the 2.5 milestone Jul 23, 2021
@Shinigami92
Copy link
Member

You removed very much from the code 🤔
But is this really a deprecation or just a "breaking change"? If so we can even remove the deprecation comment and just make it clearly visible in the changelogs

... Or in another PR I saw that we have something like a warning printer for logging a deprecation message out

@patak-dev
Copy link
Member Author

You removed very much from the code 🤔
But is this really a deprecation or just a "breaking change"? If so we can even remove the deprecation comment and just make it clearly visible in the changelogs

We should still have the option even when removing it, I'm following the same pattern that Evan used in #4371

... Or in another PR I saw that we have something like a warning printer for logging a deprecation message out

Yup, good catch. Added the runtime deprecation hints

Shinigami92
Shinigami92 previously approved these changes Jul 24, 2021
@patak-dev patak-dev changed the title refactor: deprecate polyfillDynamicImport refactor: deprecate dynamicImport polyfill Jul 27, 2021
@patak-dev patak-dev changed the title refactor: deprecate dynamicImport polyfill refactor: deprecate polyfillDynamicImport Jul 27, 2021
@patak-dev patak-dev merged commit 318cb43 into vitejs:main Jul 27, 2021
@patak-dev patak-dev deleted the refactor/deprecate-polyfillDynamicImport branch July 27, 2021 21:11
csr632 added a commit to vitejs/vite-plugin-react-pages that referenced this pull request Sep 12, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants