Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PFX certs not working (closes #4495) #4496

Closed
wants to merge 1 commit into from
Closed

fix: PFX certs not working (closes #4495) #4496

wants to merge 1 commit into from

Conversation

JohnCampionJr
Copy link

@JohnCampionJr JohnCampionJr commented Aug 4, 2021

Description

When using PFX files, localhost certs were still being generated.

In addition, Node wanted the passphrase as a buffer.

Fixes #4495

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Was causing pem/key files to be generated.  In addition, Node wanted the passphrase as a buffer.
@bluwy bluwy added p2-nice-to-have Not breaking anything but nice to have (priority) needs rebase labels Mar 14, 2022
@sapphi-red
Copy link
Member

#4495 (comment)

About passphrase Buffer problem, I think this needs to be confirmed on Node.js side first. It's not clear whether it is a documentation problem or a bug.

@sapphi-red sapphi-red closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PFX Certs are not working
4 participants