Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hmr): add server.hmr.retry option to solve frequent refresh caused by HMR WebSocket connection loss (#6089) #6090

Closed
wants to merge 1 commit into from
Closed

feat(hmr): add server.hmr.retry option to solve frequent refresh caused by HMR WebSocket connection loss (#6089) #6090

wants to merge 1 commit into from

Conversation

zhengjiaqi
Copy link

@zhengjiaqi zhengjiaqi commented Dec 13, 2021 •
edited
Loading

Description

feat(hmr): add server.hmr.retry option to solve frequent refresh caused by HMR WebSocket connection loss (#6089)

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@zhengjiaqi zhengjiaqi mentioned this pull request Dec 13, 2021
Closed
4 tasks
@ygj6
Copy link
Member

ygj6 commented Dec 30, 2021

Other related issues #5228 #5675

This was linked to issues Dec 30, 2021
Add server.hmr.retry to solve frequent refresh caused by HMR WebSocket connection loss #6089
Closed
Avoid unnecessary reload after HMR WebSocket connection lost #5675
Open
Vite tries to reconnect to websocket every second #5228
Closed
@Conduitry Conduitry mentioned this pull request Jan 13, 2022
Closed
@bluwy

This comment has been minimized.

Sign in to view
@nicks nicks mentioned this pull request Feb 9, 2022
Merged
9 tasks
@bluwy bluwy added the p2-to-be-discussed Enhancement under consideration (priority) label Mar 29, 2022
@olivierchatry
Copy link

Would be really great to have that.

@bluwy bluwy mentioned this pull request Jun 26, 2022
Closed
4 tasks
@patak-dev patak-dev added p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) and removed p2-to-be-discussed Enhancement under consideration (priority) labels Jul 8, 2022
@benmccann
Copy link
Collaborator

@zhengjiaqi thanks for this PR. It's accumulated some merge conflicts. Would you be able to rebase it?

@sapphi-red sapphi-red removed a link to an issue Jul 9, 2022
Avoid unnecessary reload after HMR WebSocket connection lost #5675
Open
4 tasks
@sapphi-red sapphi-red mentioned this pull request Jul 9, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feat: hmr p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
Team Board
Archived in project
Milestone
No milestone
7 participants
@zhengjiaqi @ygj6 @bluwy @olivierchatry @benmccann @patak-dev @Niputi