Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve array config merging #6344

Merged
merged 2 commits into from
Jan 10, 2022
Merged

fix: improve array config merging #6344

merged 2 commits into from
Jan 10, 2022

Conversation

benmccann
Copy link
Collaborator

Description

Fixes #6334

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jan 2, 2022
@patak-dev patak-dev merged commit 028cbeb into vitejs:main Jan 10, 2022
antfu pushed a commit that referenced this pull request Jan 13, 2022
@benmccann @antfu
fix: improve array config merging (#6344)
631bf45
@pi0 pi0 mentioned this pull request Jan 13, 2022
Merged
10 tasks
This was referenced Jan 13, 2022
Merged
Merged
@ryansolid ryansolid mentioned this pull request Jan 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RegExp in ssr.noExternal is ignored in SvelteKit due to config merging issue
4 participants
@benmccann @patak-dev @Shinigami92 @bluwy