Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): dynamic import in import.meta #6456

Merged
merged 1 commit into from
Jan 11, 2022
Merged

fix(types): dynamic import in import.meta #6456

merged 1 commit into from
Jan 11, 2022

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Jan 11, 2022

ref #6433

Description

import AssertOptions dynamically in importMeta.d.ts

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 5d7b4c3 into vitejs:main Jan 11, 2022
@patak-dev
Copy link
Member

Thanks @ydcjeff!

@ydcjeff ydcjeff deleted the fix/6433 branch January 11, 2022 14:44
@Shinigami92
Copy link
Member

Nothing wrong with this, but I just want to ask a question 🙂

I thought this is exactly a case why import type exist 🤔
So in emitted file it knows that the import can be fully removed and it was only for TS compile time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants