fix(plugin-legacy): polyfill latest features #7514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
commented
Mar 29, 2022
| @@ -83,4 +83,8 @@ if (isBuild) { | |||
| test('should emit css file', async () => { | |||
| expect(listAssets().some((filename) => filename.endsWith('.css'))) | |||
| }) | |||
|
|
|||
| test('includes structuredClone polyfill which is supported after core-js v3', () => { | |||
| expect(findAssetFile(/polyfills-legacy/)).toMatch('"structuredClone"') | |||
There was a problem hiding this comment.
It's hacky...
Please tell me if there is a better way.
patak-dev
approved these changes
Mar 29, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
plugin-legacy was not polyfilling features which are supported by core-js
3<.For example,
structuredCloneis supported by core-js@v3.20.0 but the polyfill was not included currently.Additional context
While looking at #7449, I found babel/babel#13701 (comment) and found this bug.
But for #7449 I think it is working correctly and this PR is not related.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).