Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle dynamic imports in dependencies #7564

Closed
wants to merge 1 commit into from

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 1, 2022

Description

Handle dynamic imports in dependencies.

Closes #6179

Additional context

I traced back the original commit to 7cbbca4#diff-ccfa1619b540f121f06e0d19a93c42f51481f573802dfd1cff67f2d0b3a42f32

It looks like that's the default behaviour all along, but it's not clear to me why so.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy
Copy link
Member Author

bluwy commented Apr 7, 2022

Putting this as draft to look into #6179 (comment)

@bluwy bluwy marked this pull request as draft April 7, 2022 15:15
@bluwy
Copy link
Member Author

bluwy commented Jun 23, 2022

Closing as I haven't got time to investigate #6179 (comment). Looking back now, the preloads may not be an easy thing to do.

@bluwy bluwy closed this Jun 23, 2022
@bluwy bluwy deleted the dynamic-import-dep branch June 23, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic imports with variables in a dependency are not processed at all
1 participant