Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use node hash #7975

Merged
merged 4 commits into from
May 11, 2022
Merged

refactor: use node hash #7975

merged 4 commits into from
May 11, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented May 1, 2022

Description

Use nodejs crypto module to generate hash for plugin-vue and plugin-vue-jsx. Also refactors around Vite core.

Additional context

Not sure if this causes issues for Vue?

Figured to do the refactor after looking at #5297. If this is merged, I don't see a reason for #5297 as node's native crypto should be the fastest (?).


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p1-chore Doesn't change code behavior (priority) label May 1, 2022
patak-dev
patak-dev previously approved these changes May 1, 2022
@patak-dev
Copy link
Member

LGTM, we already use crypto in other places, I don't see a reason to use hash-sum in the Vue plugins. It is used for CSS vars hashes in Vue core but it doesn't seem that the plugins are trying to replicate the same hashes. @sodatea maybe you could also check the PR? Just in case there is a reason we are missing here.

@patak-dev patak-dev requested a review from haoqunjiang May 1, 2022 15:00
@patak-dev patak-dev merged commit 5ce7c74 into vitejs:main May 11, 2022
@bluwy bluwy deleted the refactor-hash branch May 12, 2022 02:57
@patak-dev patak-dev mentioned this pull request May 16, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants