perf(lib): reduce backtrack when injecting esbuild helpers (fixes #8099) #8110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This line was consuming a lot of time.
vite/packages/vite/src/node/plugins/esbuild.ts
Lines 276 to 279 in bb603d3
This PR changes regex to reduce backtracks.
I confirmed #8099 works with this PR.
#8099 is about umd but it happens with iife in theory and this PR fixes it too.
fixes #8099
refs #7948
Additional context
rollup repl (named exports + iife)
rollup repl (named exports + umd)
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).