Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tweak server start output #8582

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 14, 2022

Description

has a different width with depending on fonts. This PR replaces that letter and tweaks some messages.

image
image

@patak-dev You suggested (U+279C) but how about (U+2756)? It has the same width (East Asian Width, East Asian Width data).

letter width
ⓘ (U+24BE) East Asian Ambiguous (A)
➜ (U+279C) Neutral (N)
❖ (U+2756) Neutral (N)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Jun 14, 2022
@patak-dev
Copy link
Member

patak-dev commented Jun 14, 2022

The ❖ looks ok. Here are some screenshot of my terminal with it:

image

image

image

The blue color seems a bit off when used together with the other ones. Maybe using no color here (the last white one) is better?

@sapphi-red
Copy link
Member Author

White one was ok for my terminal too. 👍

@patak-dev patak-dev merged commit 3439132 into vitejs:main Jun 14, 2022
@sapphi-red sapphi-red deleted the chore/tweak-server-start-output branch June 14, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants