Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: json plugin add judgment and filtering of BOM tags #8628

Merged
merged 6 commits into from
Jun 17, 2022
Merged

fix: json plugin add judgment and filtering of BOM tags #8628

merged 6 commits into from
Jun 17, 2022

Conversation

zhenzhenChange
Copy link
Contributor

Description

vite:json Add judgment and filtering of BOM tags. #8611

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@zhenzhenChange zhenzhenChange changed the title fix: son plugin add judgment and filtering of BOM tags fix: json plugin add judgment and filtering of BOM tags Jun 17, 2022
@sapphi-red sapphi-red added the p2-edge-case Bug, but has workaround or limited in scope (priority) label Jun 17, 2022
@sapphi-red sapphi-red linked an issue Jun 17, 2022 that may be closed by this pull request
Failed to parse JSON file. #8611
Closed
7 tasks
sapphi-red
sapphi-red previously approved these changes Jun 17, 2022
View reviewed changes
packages/vite/src/node/plugins/importAnalysis.ts Outdated Show resolved Hide resolved
packages/vite/src/node/plugins/json.ts Outdated Show resolved Hide resolved
patak-dev and others added 2 commits June 17, 2022 08:53
@patak-dev @sapphi-red
chore: remove comment
7a96d0b 
Co-authored-by: 翠 / green <green@sapphi.red>
@patak-dev @sapphi-red
chore: remove comment
311cf99 
Co-authored-by: 翠 / green <green@sapphi.red>
@patak-dev patak-dev merged commit e10530b into vitejs:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@patak-dev patak-dev patak-dev approved these changes

@sapphi-red sapphi-red sapphi-red left review comments

Assignees
No one assigned
Labels
p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to parse JSON file.
4 participants
@zhenzhenChange @patak-dev @bluwy @sapphi-red