fix: respect rollupOptions.external
for transitive dependencies
#8679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The regression was brought in by #8280
To be compatible with Vite 2.x behavior:
When
rollupOptions.external
is set to['vue']
,import ... from 'vue'
in dependencies should be preserved;const Vue = require('vue')
in dependencies should be transformed toimport * as Vue from 'vue'
and be preserved;Ideally, we need a first-class
build.external
option, but that belongs to another issue/PR. It's fine to postpone it after 3.0 stable is out.Remaining issues in this PR:
rollupOptions.external
only acceptsstring[] | string
in the current implementationoptimizeDeps.exclude
only supportsstring[]
RegExp | RegExp[]
and function formats https://rollupjs.org/guide/en/#externaloptimizeDeps.exclude
, either exposing it internally, or open to all end users.external
implementation is naive, there could potentially be more edge cases than in v2. But I think it's acceptable, because this use case shouldn't be encouraged at all.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).