-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-react): process excluded files (fix #6921) #8758
Conversation
✅ Deploy Preview for vite-docs-main canceled.
|
I think this is a breaking change as the behavior is documented that I'm not much familiar with react, but I suppose adding a different property like |
I think this PR's way of using |
Sounds good to me. @aleclarson ping so you're aware too. Let us know if you have an issue with the change. |
Maybe this one is doing slightly similar? #6202 |
Yeah I think #6202 is a better approach. Someone should write tests for it 😁 |
@aleclarson Yeah, I'm willing to write some tests for #6202, but I found there are some conflicts need to be resolved, could you make a |
@ZYSzys I will rebase it sometime in the next few days, thanks! |
Closing this PR as #6202 seems like a better solution for the folks involved. @ZYSzys if you are going to add tests, you could fork @aleclarson PR, rebase, and push it yourself to the new plugin-react repository. |
Description
Do
filter(id)
on top of transform function to exclude files.Fixes vitejs/vite-plugin-react#24
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes vitejs/vite#123
).