feat: inject module scripts into head instead of body (fixes #881) #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underfin
approved these changes
Oct 10, 2020
antfu
approved these changes
Oct 11, 2020
aleclarson
approved these changes
Oct 16, 2020
|
I disagree with this PR as it's not respecting the users template. If the user wants script in head, the template should have the script in head to start with. I filed #1050 but it was closed. <head>
<link rel="modulepreload" href="super-critical-stuff.mjs">
</head>
[...]
<script type="module" src="super-critical-stuff.mjs"> |
This was referenced Nov 10, 2020
isaacl
added a commit
to isaacl/vite
that referenced
this pull request
Nov 11, 2020
- injectPreload for entry chunk - move script injection back to end of body (reverts vitejs#882) - fix indentation of injectPreload, injectCSS and injectScript Fixes vitejs#1050, see also vitejs#881.
isaacl
added a commit
to isaacl/vite
that referenced
this pull request
Nov 11, 2020
- injectPreload for entry chunk - move script injection back to end of body (reverts vitejs#882) - fix indentation of injectPreload, injectCSS and injectScript Fixes vitejs#1050, see also vitejs#881.
|
I disagree too, eg: I want something |
|
@wangcongyi this PR was for vite 1.0, it is no longer relevant for 2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure if this should be configurable or if body should be used as a fallback in case head does not exist.