Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: css content tests #8873

Merged
merged 2 commits into from
Jul 1, 2022
Merged

test: css content tests #8873

merged 2 commits into from
Jul 1, 2022

Conversation

sapphi-red
Copy link
Member

Description

This PR adds test for #8245, #8461 which was fixed by #8278, #8471.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels Jul 1, 2022
@netlify
Copy link

netlify bot commented Jul 1, 2022 •
edited
Loading

✅ Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit 5f2c76a
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62be803eccc4e0000828453b
😎 Deploy Preview https://deploy-preview-8873--vite-docs-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sapphi-red sapphi-red marked this pull request as draft July 1, 2022 04:20
@sapphi-red sapphi-red mentioned this pull request Jul 1, 2022
Merged
9 tasks
@sapphi-red sapphi-red marked this pull request as ready for review July 1, 2022 05:10
@patak-dev patak-dev merged commit 24a9469 into vitejs:main Jul 1, 2022
@sapphi-red sapphi-red deleted the test/css-content branch July 1, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapphi-red @patak-dev