fix(hmr): set isSelfAccepting unless it is delayed

[sapphi-red]

Description

In the following situation, a full reload should happen.

• main.css depends on index.liquid by tailwind.
• index.liquid's hmr is not handled by anything
• edited index.liquid

The full reload was not happening because isSelfAccepting was undefined.

This PR changes isSelfAccepting to be set unless ensureEntryFromUrl is called from import-analysis.
The old behavior is to set isSelfAccepting if isHTMLRequest(url) || canSkipImportAnalysis(url) is true.

refs #7561 #7895 #7898

Additional context

Found while checking #8890.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[sapphi-red]

When updates was [] the config.logger.info below was outputing 22:42:33 [vite] .

[netlify]

✅ Deploy Preview for vite-docs-main ready!

Name	Link
🔨 Latest commit	946ebb0
🔍 Latest deploy log	https://app.netlify.com/sites/vite-docs-main/deploys/62c19c5edffbfe000838b609
😎 Deploy Preview	https://deploy-preview-8898--vite-docs-main.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[patak-dev]

This is a lot safer, thanks Sapphi. @brillout, you may also want to review in case there is a regression here.

[brillout]

Looks good 👍. I'll test it on vite-plugin-ssr's HMR test suite as soon as it's released.

[patak-dev]

Released as v3.0.0-beta.6 @brillout

[brillout]

HMR tests are still green with beta.6.

[aleclarson]

I really don't like the naming used here.. 😬

As I understand it, we are setting isSelfAccepting to false in the ModuleNode constructor in order to allow HMR update propagation, because propagation is prevented when isSelfAccepting is undefined. Is that right?

If so, maybe allowHmrPropagation would be a better name for this argument (instead of setIsSelfAccepting). Although, it seems a little hacky to be overloading isSelfAccepting === undefined to mean "prevent HMR propagation".

[aleclarson]

This comment is a little confusing. We should move it closer to what it's referencing (above the canSkipImportAnalysis call) and explain why it's necessary.

[patak-dev]

I think allowHmrPropagation would also be confusing here. Maybe delayHmrPropagation? The gist of the issue in vite-plugin-ssr that @brillout found was that HMR was being triggered for modules that haven't yet been loaded by the browser (so making isSelfAccepting undefined until we know its value, that is correct independent of this issue because if not we are guessing, also fixed his issue).

Maybe the parameter should be called isSelfAccepting and by default it is undefined, meaning that when we are creating the module, we don't yet know (we need to do import analysis to find out). And if you pass true or false, it means you do know the proper value at creation time. I can do a PR to change it to this if you think it is better @sapphi-red @aleclarson

[aleclarson]

Maybe the parameter should be called isSelfAccepting and by default it is undefined, meaning that when we are creating the module, we don't yet know (we need to do import analysis to find out). And if you pass true or false, it means you do know the proper value at creation time.

👍

[brillout]

I think allowHmrPropagation would also be confusing here. Maybe delayHmrPropagation? The gist of the issue in vite-plugin-ssr that @brillout found was that HMR was being triggered for modules that haven't yet been loaded by the browser (so making isSelfAccepting undefined until we know its value, that is correct independent of this issue because if not we are guessing, also fixed his issue).

Exactly.

[patak-dev]

@aleclarson PR refactoring from setIsSelfAccepted to { isSelfAccepted: boolean | undefined } here:

• chore: setIsSelfAccepting param to isSelfAccepting #10960