perf: bundle create-vite #9034
Merged
perf: bundle create-vite #9034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
the
p2-nice-to-have
✅ Deploy Preview for vite-docs-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sapphi-red
commented
Jul 11, 2022
| @@ -0,0 +1,126 @@ | |||
| // @ts-check | |||
There was a problem hiding this comment.
this file needs to be js because it is imported from packages/vite/rollup.plugin.ts and it won't be transpiled.
✅ Deploy Preview for vite-docs-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bluwy
previously approved these changes
Jul 14, 2022
Merged
9 tasks
|
@sapphi-red would you resolve the conflicts when you have a chance? I think we could release this in tandem with the next Vite minor (as a new create-vite minor) |
|
@patak-dev Which should I rebase on, main or #9406? |
|
@sapphi-red mmm... let's wait for today's meeting, we may have a decision about #9406 then. |
|
Looks like #9406 is merged, so this can be rebased on |
sapphi-red
force-pushed
the
perf/bundle-create-vite
branch
from
af67914 to
02caedf
Compare
sapphi-red
force-pushed
the
perf/bundle-create-vite
branch
from
02caedf to
c785eec
Compare
sapphi-red
force-pushed
the
perf/bundle-create-vite
branch
from
c785eec to
fb49a3b
Compare
|
I've rebased on main 👍 |
patak-dev
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bundles and minifies create-vite to reduce download time and requests.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).