Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: server.proxy ws error causes crash #9123

Merged
merged 1 commit into from
Jul 14, 2022
Merged

fix: server.proxy ws error causes crash #9123

merged 1 commit into from
Jul 14, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 14, 2022 •
edited
Loading

Description

When an error happens proxying ws, Vite crashed with TypeError: res.writeHead is not a function error.

Reported by #9120
Reproduction: https://stackblitz.com/edit/vitejs-vite-mlwcqv?file=vite.config.js,main.js

refs #7398

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jul 14, 2022
@netlify
Copy link

netlify bot commented Jul 14, 2022 •
edited
Loading

✅ Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 2192991
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62d047ca175a3600095b5250

@patak-dev patak-dev merged commit c2426d1 into vitejs:main Jul 14, 2022
@sapphi-red sapphi-red deleted the fix/server-proxy-ws-error-crash branch July 15, 2022 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sapphi-red @patak-dev @bluwy