Highlight more levels of statistical significance #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When comparing two benchmarks, we used to always have this black and white view of the result: either their significant or they are not. Which in some cases it can be a form of injustice, for instance a p-value of 0.053 would be considered insignificant, thus marked in flashy red, and the delta would not be highlighted, even though the p-value is very close to our threshold (0.050).
Instead, we now have four different level of statistical significance in the UI:
Statistically Significant(p <= 0.01),Moderate Significance(p <= 0.05),Marginal Significance(p <= 0.1),Not Statistically Significant(p > 0.1).Before
After
