Bypass cobra completion commands so they still function (#14217)

vitessio · Oct 10, 2023 · 824c8e9 · 824c8e9
1 parent f119796
commit 824c8e9
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/go/cmd/vtctldclient/command/root.go b/go/cmd/vtctldclient/command/root.go
@@ -136,6 +136,13 @@ func getClientForCommand(cmd *cobra.Command) (vtctldclient.VtctldClient, error)
 		}
 	}
 
+	// Reserved cobra commands for shell completion that we don't want to fail
+	// here.
+	switch {
+	case cmd.Name() == "__complete", cmd.Parent() != nil && cmd.Parent().Name() == "completion":
+		return nil, nil
+	}
+
 	if VtctldClientProtocol != "local" && server == "" {
 		return nil, errNoServer
 	}