Skip to content

Commit

Permalink
clean up
Browse files Browse the repository at this point in the history
Signed-off-by: Andres Taylor <andres@planetscale.com>
  • Loading branch information
systay committed Jul 6, 2021
1 parent 9caf520 commit acdb794
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
5 changes: 0 additions & 5 deletions go/vt/vtgate/planbuilder/symtab.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ package planbuilder
import (
"errors"
"fmt"
"runtime"
"strconv"
"strings"

Expand Down Expand Up @@ -389,10 +388,6 @@ func ResultFromNumber(rcs []*resultColumn, val *sqlparser.Literal, caller string
return 0, fmt.Errorf("error parsing column number: %s", sqlparser.String(val))
}
if num < 1 || num > int64(len(rcs)) {
_, file, no, ok := runtime.Caller(1)
if ok {
fmt.Printf("called from %s#%d\n", file, no)
}
return 0, vterrors.NewErrorf(vtrpcpb.Code_INVALID_ARGUMENT, vterrors.BadFieldError, "Unknown column '%d' in '%s'", num, caller)
}
return int(num - 1), nil
Expand Down
7 changes: 0 additions & 7 deletions go/vt/vtgate/planbuilder/testdata/onecase.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1 @@
# Add your test case here for debugging and run go test -run=One.
"select num, count(id) from user"
{

}
{

}

0 comments on commit acdb794

Please sign in to comment.