VTOrc: Update the primary key for all the tables from `hostname, port…

…` to `alias` (#13243) * feat: remove unused code and rename orchestrator file Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove code for hostname resolution since it is unrequired Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove more unused code and tables Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove database_instance_downtime from VTOrc as we weren't inserting into it Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: get rid of group replication information that isn't required Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix bugs Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix insert queries for test Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: introduce alias in all the tables and use it as the primary key and for joins Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix all the unit tests Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix end to end test expectations Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove unused parameters Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add test for auditInstanceAnalysisInChangelog Signed-off-by: Manan Gupta <manan@planetscale.com> * test: augment test to also verify reading of audit operations works as intended Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove generics code in VTOrc around durability policies since it is not required anymore Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add tests for more functions changed in this PR Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: refactor forgetting instance code a little and add tests for it Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix snapshot topologies code and add test for it Signed-off-by: Manan Gupta <manan@planetscale.com> * test: add tests for savetablet and readtablet Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix remaining tests Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix comment Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com>
vitessio · Jun 20, 2023 · bf7064e · bf7064e
1 parent c954324
commit bf7064e
Show file tree

Hide file tree

Showing 50 changed files with 1,348 additions and 4,118 deletions.
diff --git a/go/test/endtoend/vtorc/api/api_test.go b/go/test/endtoend/vtorc/api/api_test.go
@@ -115,20 +115,20 @@ func TestAPIEndpoints(t *testing.T) {
 			return response == "[]"
 		})
 		assert.Equal(t, 200, status, resp)
-		assert.Contains(t, resp, fmt.Sprintf(`"Port": %d`, replica.MySQLPort))
+		assert.Contains(t, resp, fmt.Sprintf(`"AnalyzedInstanceAlias": "%s"`, replica.Alias))
 		assert.Contains(t, resp, `"Analysis": "ReplicationStopped"`)
 
 		// Verify that filtering also works in the API as intended
 		status, resp, err = utils.MakeAPICall(t, vtorc, "/api/replication-analysis?keyspace=ks&shard=0")
 		require.NoError(t, err)
 		assert.Equal(t, 200, status, resp)
-		assert.Contains(t, resp, fmt.Sprintf(`"Port": %d`, replica.MySQLPort))
+		assert.Contains(t, resp, fmt.Sprintf(`"AnalyzedInstanceAlias": "%s"`, replica.Alias))
 
 		// Verify that filtering by keyspace also works in the API as intended
 		status, resp, err = utils.MakeAPICall(t, vtorc, "/api/replication-analysis?keyspace=ks")
 		require.NoError(t, err)
 		assert.Equal(t, 200, status, resp)
-		assert.Contains(t, resp, fmt.Sprintf(`"Port": %d`, replica.MySQLPort))
+		assert.Contains(t, resp, fmt.Sprintf(`"AnalyzedInstanceAlias": "%s"`, replica.Alias))
 
 		// Check that filtering using keyspace and shard works
 		status, resp, err = utils.MakeAPICall(t, vtorc, "/api/replication-analysis?keyspace=ks&shard=80-")

diff --git a/go/test/endtoend/vtorc/readtopologyinstance/main_test.go b/go/test/endtoend/vtorc/readtopologyinstance/main_test.go
@@ -71,12 +71,11 @@ func TestReadTopologyInstanceBufferable(t *testing.T) {
 		}
 	}
 
-	primaryInstance, err := inst.ReadTopologyInstanceBufferable(&inst.InstanceKey{
-		Hostname: utils.Hostname,
-		Port:     primary.MySQLPort,
-	}, nil)
+	primaryInstance, err := inst.ReadTopologyInstanceBufferable(primary.Alias, nil)
 	require.NoError(t, err)
 	require.NotNil(t, primaryInstance)
+	assert.Equal(t, utils.Hostname, primaryInstance.Hostname)
+	assert.Equal(t, primary.MySQLPort, primaryInstance.Port)
 	assert.Contains(t, primaryInstance.InstanceAlias, "zone1")
 	assert.NotEqual(t, 0, primaryInstance.ServerID)
 	assert.Greater(t, len(primaryInstance.ServerUUID), 10)
@@ -120,12 +119,11 @@ func TestReadTopologyInstanceBufferable(t *testing.T) {
 	err = logic.EnableRecovery()
 	require.NoError(t, err)
 
-	replicaInstance, err := inst.ReadTopologyInstanceBufferable(&inst.InstanceKey{
-		Hostname: utils.Hostname,
-		Port:     replica.MySQLPort,
-	}, nil)
+	replicaInstance, err := inst.ReadTopologyInstanceBufferable(replica.Alias, nil)
 	require.NoError(t, err)
 	require.NotNil(t, replicaInstance)
+	assert.Equal(t, utils.Hostname, replicaInstance.Hostname)
+	assert.Equal(t, replica.MySQLPort, replicaInstance.Port)
 	assert.Contains(t, replicaInstance.InstanceAlias, "zone1")
 	assert.NotEqual(t, 0, replicaInstance.ServerID)
 	assert.Greater(t, len(replicaInstance.ServerUUID), 10)
@@ -137,6 +135,8 @@ func TestReadTopologyInstanceBufferable(t *testing.T) {
 	assert.Equal(t, "ROW", replicaInstance.BinlogFormat)
 	assert.Equal(t, "ON", replicaInstance.GTIDMode)
 	assert.Equal(t, "FULL", replicaInstance.BinlogRowImage)
+	assert.Equal(t, utils.Hostname, replicaInstance.SourceHost)
+	assert.Equal(t, primary.MySQLPort, replicaInstance.SourcePort)
 	assert.Contains(t, replicaInstance.SelfBinlogCoordinates.LogFile, fmt.Sprintf("vt-0000000%d-bin", replica.TabletUID))
 	assert.Greater(t, replicaInstance.SelfBinlogCoordinates.LogPos, uint32(0))
 	assert.False(t, replicaInstance.SemiSyncPrimaryEnabled)

diff --git a/go/vt/topotools/tablet.go b/go/vt/topotools/tablet.go
@@ -245,3 +245,29 @@ func TabletIdent(tablet *topodatapb.Tablet) string {
 func TargetIdent(target *querypb.Target) string {
 	return fmt.Sprintf("%s/%s (%s)", target.Keyspace, target.Shard, target.TabletType)
 }
+
+// TabletEquality returns true iff two Tablets are identical for testing purposes
+func TabletEquality(left, right *topodatapb.Tablet) bool {
+	if left.Keyspace != right.Keyspace {
+		return false
+	}
+	if left.Shard != right.Shard {
+		return false
+	}
+	if left.Hostname != right.Hostname {
+		return false
+	}
+	if left.Type != right.Type {
+		return false
+	}
+	if left.MysqlHostname != right.MysqlHostname {
+		return false
+	}
+	if left.MysqlPort != right.MysqlPort {
+		return false
+	}
+	if left.PrimaryTermStartTime.String() != right.PrimaryTermStartTime.String() {
+		return false
+	}
+	return topoproto.TabletAliasString(left.Alias) == topoproto.TabletAliasString(right.Alias)
+}
diff --git a/go/vt/vtorc/config/config.go b/go/vt/vtorc/config/config.go
@@ -46,9 +46,7 @@ const (
 	DiscoveryQueueCapacity                = 100000
 	DiscoveryQueueMaxStatisticsSize       = 120
 	DiscoveryCollectionRetentionSeconds   = 120
-	HostnameResolveMethod                 = "default"
 	UnseenInstanceForgetHours             = 240 // Number of hours after which an unseen instance is forgotten
-	ExpiryHostnameResolvesMinutes         = 60  // Number of minutes after which to expire hostname-resolves
 	CandidateInstanceExpireMinutes        = 60  // Minutes after which a suggestion to use an instance as a candidate replica (to be preferably promoted on primary failover) is expired.
 	FailureDetectionPeriodBlockMinutes    = 60  // The time for which an instance's failure discovery is kept "active", so as to avoid concurrent "discoveries" of the instance's failure; this preceeds any recovery process, if any.
 )

diff --git a/go/vt/vtorc/db/db.go b/go/vt/vtorc/db/db.go
@@ -72,7 +72,7 @@ func translateStatement(statement string) string {
 	return sqlutils.ToSqlite3Dialect(statement)
 }
 
-// registerVTOrcDeployment updates the vtorc_metadata table upon successful deployment
+// registerVTOrcDeployment updates the vtorc_db_deployments table upon successful deployment
 func registerVTOrcDeployment(db *sql.DB) error {
 	query := `
     	replace into vtorc_db_deployments (
@@ -82,7 +82,7 @@ func registerVTOrcDeployment(db *sql.DB) error {
 			)
 				`
 	if _, err := execInternal(db, query, ""); err != nil {
-		log.Fatalf("Unable to write to vtorc_metadata: %+v", err)
+		log.Fatalf("Unable to write to vtorc_db_deployments: %+v", err)
 	}
 	return nil
 }
@@ -188,15 +188,3 @@ func QueryVTOrc(query string, argsArray []any, onRow func(sqlutils.RowMap) error
 
 	return err
 }
-
-// ReadTimeNow reads and returns the current timestamp as string. This is an unfortunate workaround
-// to support both MySQL and SQLite in all possible timezones. SQLite only speaks UTC where MySQL has
-// timezone support. By reading the time as string we get the database's de-facto notion of the time,
-// which we can then feed back to it.
-func ReadTimeNow() (timeNow string, err error) {
-	err = QueryVTOrc(`select now() as time_now`, nil, func(m sqlutils.RowMap) error {
-		timeNow = m.GetString("time_now")
-		return nil
-	})
-	return timeNow, err
-}